[webkit-reviews] review granted: [Bug 130817] Add a _WKScriptWorld class : [Attachment 227915] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 130817: Add a _WKScriptWorld class
https://bugs.webkit.org/show_bug.cgi?id=130817

Attachment 227915: Patch
https://bugs.webkit.org/attachment.cgi?id=227915&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=227915&action=review


> Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.mm:79
> +- (BOOL)isEqual:(id)object
> +{
> +    if (![object isKindOfClass:[_WKScriptWorld class]])
> +	   return NO;
> +
> +    return _worldID == ((_WKScriptWorld *)object)->_worldID;
> +}
> +
> +- (NSUInteger)hash
> +{
> +    return _worldID;
> +}

This seems premature.