[webkit-reviews] review granted: [Bug 130811] Convert more of HTMLConverter to C++ : [Attachment 227907] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 130811: Convert more of HTMLConverter to C++
https://bugs.webkit.org/show_bug.cgi?id=130811

Attachment 227907: Patch
https://bugs.webkit.org/attachment.cgi?id=227907&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227907&action=review


> Source/WebCore/editing/cocoa/HTMLConverter.mm:1357
> +    auto result = m_attributesForElements.add(&coreElement, nullptr);
> +    if (result.isNewEntry)
> +	   result.iterator->value = _computedAttributesForElement(coreElement);


I think you should do 

auto& attributes = m_attributesForElements.add(&coreElement,
nullptr).iterator->value;
if (!attributes)
    attributes = _computedAttributesForElement(coreElement);

> Source/WebCore/editing/cocoa/HTMLConverter.mm:1566
> +    NSString *width = element.getAttribute(WebCore::HTMLNames::widthAttr);

Does this do the right thing for table cell elements now?