[webkit-reviews] review granted: [Bug 130779] FEGaussianBlur: unify and const-ify calculateKernelSize : [Attachment 227902] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Adenilson Cavalcanti
Silva <savagobr at yahoo.com>'s request for review:
Bug 130779: FEGaussianBlur: unify and const-ify calculateKernelSize
https://bugs.webkit.org/show_bug.cgi?id=130779

Attachment 227902: Patch
https://bugs.webkit.org/attachment.cgi?id=227902&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227902&action=review


> Source/WebCore/platform/graphics/filters/Filter.h:49
> +    // TODO: verify descendants that overload this method and turn them to
const.

Not sure why you need the comment. AFAICT all subclasses use "override" so you
would get a build failure with mismatched signatures.