[webkit-reviews] review denied: [Bug 130790] [CSS Shapes] Remove shape-inside bits from the web inspector : [Attachment 227887] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 26 14:49:07 PDT 2014


Timothy Hatcher <timothy at apple.com> has denied Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 130790: [CSS Shapes] Remove shape-inside bits from the web inspector
https://bugs.webkit.org/show_bug.cgi?id=130790

Attachment 227887: Patch
https://bugs.webkit.org/attachment.cgi?id=227887&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
Both of these files come from CodeMirror, and we don't edit them. In practice
they are not used either. Other code in WebInspector replaces the set of
supported properties that we get dynamically from WebCore.
CSSKeywordCompletions.js might normally need editing, but I don't see
shape-inside in there — only shape-outside.


More information about the webkit-reviews mailing list