[webkit-reviews] review granted: [Bug 130665] [GTK] [TextureMapper] Weird brightness with some videos with acceletared compositing : [Attachment 227874] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 130665: [GTK] [TextureMapper] Weird brightness with some videos with
acceletared compositing
https://bugs.webkit.org/show_bug.cgi?id=130665

Attachment 227874: Patch
https://bugs.webkit.org/attachment.cgi?id=227874&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=227874&action=review


> Source/WebCore/ChangeLog:8
> +	   No new tests needed, current set suffices.

They don't actually! You need to tell the truth here which is is that we do not
yet have the ability to test accelerated composited contents on the bots.

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:50
> +	   None = 0x00,

None should probably be called NoFlag and you should use 0 here instead of
0x00.