[webkit-reviews] review denied: [Bug 130779] FEGaussianBlur: unify and const-ify calculateKernelSize : [Attachment 227864] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Adenilson Cavalcanti
Silva <savagobr at yahoo.com>'s request for review:
Bug 130779: FEGaussianBlur: unify and const-ify calculateKernelSize
https://bugs.webkit.org/show_bug.cgi?id=130779

Attachment 227864: Patch
https://bugs.webkit.org/attachment.cgi?id=227864&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227864&action=review


> Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:410
> +    FloatPoint
stdFilterScaled(filter->applyHorizontalScale(stdDeviation.x()),
filter->applyVerticalScale(stdDeviation.y()));

Since you dereference filter without a null check, you should make it a const
Filter&