[webkit-reviews] review denied: [Bug 130779] FEGaussianBlur: unify and const-ify calculateKernelSize : [Attachment 227857] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 26 10:24:08 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Adenilson Cavalcanti
Silva <savagobr at yahoo.com>'s request for review:
Bug 130779: FEGaussianBlur: unify and const-ify calculateKernelSize
https://bugs.webkit.org/show_bug.cgi?id=130779

Attachment 227857: Patch
https://bugs.webkit.org/attachment.cgi?id=227857&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227857&action=review


> Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:408
> +IntSize FEGaussianBlur::calculateKernelSize(Filter* filter, const
FloatPoint& std)

const Filter* ?
Please rename "std" to something better (is it stdDeviation?)


More information about the webkit-reviews mailing list