[webkit-reviews] review granted: [Bug 130010] [CSS Grid Layout] getComputedStyle() must return the specified value for positioning properties : [Attachment 227848] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 130010: [CSS Grid Layout] getComputedStyle() must return the specified
value for positioning properties
https://bugs.webkit.org/show_bug.cgi?id=130010

Attachment 227848: Patch
https://bugs.webkit.org/attachment.cgi?id=227848&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227848&action=review


> Source/WebCore/rendering/RenderGrid.cpp:890
> +    const auto& linesIterator = namedLinesMap.find(lineName);

Should just be auto, rather than const auto&.

> Source/WebCore/rendering/RenderGrid.cpp:910
> +    const auto& areaIterator = gridAreaMap.find(namedGridAreaOrGridLine);

Should just be auto rather than const auto&.

> Source/WebCore/rendering/RenderGrid.cpp:921
> +	   String gridAreaName = namedGridAreaOrGridLine.substring(0,
namedGridAreaOrGridLine.length() - suffixLength);

I know I asked this last time, but what guarantees this is not an empty string?
If namedGridAreaOrGridLine is "-end" then I think this code will call find on
an empty string, which does not work.

> Source/WebCore/rendering/RenderGrid.cpp:923
> +	   const auto& areaIterator = gridAreaMap.find(gridAreaName);

Should just be auto rather than const auto&.