[webkit-reviews] review granted: [Bug 130763] Add a new type of scrolling tree node for overflow scrolling : [Attachment 227827] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 130763: Add a new type of scrolling tree node for overflow scrolling
https://bugs.webkit.org/show_bug.cgi?id=130763

Attachment 227827: Patch
https://bugs.webkit.org/attachment.cgi?id=227827&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227827&action=review


> Source/WebCore/page/scrolling/ScrollingStateNode.h:155
> +    bool isFixedNode() const { return nodeType() == FixedNode; }

why do these use nodeType() instead of m_nodeType? (not that it matters)

> Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.mm:151
> +    case OverflowScrollingNode: // Not yet created on Mac.

Maybe this could be better documented with an ASSERT_NOT_REACHED() and return
null? That will be easier to find when we implement
scrolling-tree-overflow-scroll on Mac.