[webkit-reviews] review granted: [Bug 130603] [iOS] Enable caption support in full screen. : [Attachment 227775] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 25 13:53:20 PDT 2014


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 130603: [iOS] Enable caption support in full screen.
https://bugs.webkit.org/show_bug.cgi?id=130603

Attachment 227775: Patch
https://bugs.webkit.org/attachment.cgi?id=227775&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227775&action=review


>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.h:33
> +#include <wtf/WeakPtr.h>

Is this required?

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:814
> +	   CGRect textFrame = m_videoLayer ? [m_videoLayer videoRect] :
(CGRect)frame;

Can't you use static_cast<CGRect>() ?

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:1493
> +	   CGRect frame = CGRectMake(0, 0, m_videoFullscreenFrame.width(),
m_videoFullscreenFrame.height());

Nit: this local isn't really necessary.


More information about the webkit-reviews mailing list