[webkit-reviews] review granted: [Bug 129589] Repatch should plant calls to getters directly rather than through a C helper : [Attachment 227779] it compiles and doesn't crash

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 129589: Repatch should plant calls to getters directly rather than through
a C helper
https://bugs.webkit.org/show_bug.cgi?id=129589

Attachment 227779: it compiles and doesn't crash
https://bugs.webkit.org/attachment.cgi?id=227779&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227779&action=review


r=me after running 32-bit tests :-)

> Source/JavaScriptCore/jit/Repatch.cpp:343
> +	       // Therefore, we temporary grow the stack for the purpose of the
call and then

temporarily

> Source/JavaScriptCore/jit/Repatch.cpp:344
> +	       // degrow it after.

s/degrow/shrink