[webkit-reviews] review denied: [Bug 130709] [iOS] Inspector View Indication Support : [Attachment 227780] [PATCH] Renamed methods and classes

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 130709: [iOS] Inspector View Indication Support
https://bugs.webkit.org/show_bug.cgi?id=130709

Attachment 227780: [PATCH] Renamed methods and classes
https://bugs.webkit.org/attachment.cgi?id=227780&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227780&action=review


> Source/WebKit2/UIProcess/WebPageProxy.h:1325
> +    void startIndicating();
> +    void stopIndicating();

"indicating" is still too vague here. There may be many kinds of indication, of
which Inspector overlays may be just one.

> Source/WebKit2/WebProcess/WebPage/WebPage.h:472
> +    void indicate();
> +    void hideIndication();

Also too vague, and annoyingly different terminology to that on PageClient.