[webkit-reviews] review granted: [Bug 130729] [iOS] Playing video does not disable display sleep. : [Attachment 227773] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 25 11:42:06 PDT 2014
Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 130729: [iOS] Playing video does not disable display sleep.
https://bugs.webkit.org/show_bug.cgi?id=130729
Attachment 227773: Patch
https://bugs.webkit.org/attachment.cgi?id=227773&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227773&action=review
> Source/WebCore/platform/DisplaySleepDisabler.h:33
> + static std::unique_ptr<DisplaySleepDisabler> create(const char* reason);
Nit: "reason" isn't necessary.
>
Source/WebCore/platform/cocoa/DisplaySleepDisablerCocoa.hSource/WebCore/platfor
m/mac/DisplaySleepDisabler.h:40
> + DisplaySleepDisablerCocoa(const char* reason);
Ditto.
More information about the webkit-reviews
mailing list