[webkit-reviews] review denied: [Bug 130694] Track plugin in visibility in the plugin process. : [Attachment 227682] patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Stephanie Lewis
<slewis at apple.com>'s request for review:
Bug 130694: Track plugin in visibility in the plugin process.
https://bugs.webkit.org/show_bug.cgi?id=130694

Attachment 227682: patch
https://bugs.webkit.org/attachment.cgi?id=227682&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227682&action=review


I don't think this handles the case where a web process crashes.

> Source/WebKit2/PluginProcess/PluginProcess.cpp:243
> +void PluginProcess::webProcessesWithVisiblePluginsChanged(bool isVisible)
> +{
> +    isVisible ? m_visiblePluginsActivity.increment() :
m_visiblePluginsActivity.decrement();
> +}

I think having two functions, one for "didBecomeHidden" and one for
"didBecomeVisible" is more clear.

> Source/WebKit2/PluginProcess/WebProcessConnection.cpp:342
> +    if (oldState != m_visiblePluginInstanceIDs.isEmpty()) {
> +	  
PluginProcess::shared().webProcessesWithVisiblePluginsChanged(isVisible);
> +    }

Single line if bodies shouldn't have braces.