[webkit-reviews] review granted: [Bug 130540] InlineIterator position (unsigned int) variable can wrap around : [Attachment 227728] InlineIterator has new boolean value

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 130540: InlineIterator position (unsigned int) variable can wrap around
https://bugs.webkit.org/show_bug.cgi?id=130540

Attachment 227728: InlineIterator has new boolean value
https://bugs.webkit.org/attachment.cgi?id=227728&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227728&action=review


Much more understandable!

> Source/WebCore/rendering/line/BreakingContextInlineHeaders.h:1072
> +		   unsigned endpointOffset = endpoint.offset();
> +		   if (endpointOffset)
> +		       endpoint.setOffset(endpointOffset - 1);
> +		   else
> +		       endpoint.setRefersToEndOfPreviousNode();

Seems like this could be a method on InlineIterator.