[webkit-reviews] review granted: [Bug 128684] Implement hasLiveStreamingContent property in WebAVPlayerController : [Attachment 227512] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 128684: Implement hasLiveStreamingContent property in WebAVPlayerController
https://bugs.webkit.org/show_bug.cgi?id=128684

Attachment 227512: Patch
https://bugs.webkit.org/attachment.cgi?id=227512&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227512&action=review


> Source/WebCore/platform/ios/WebVideoFullscreenInterface.h:33
> +#import <WebCore/TimeRanges.h>

Don't include the header unless you need the implementation. Instead,
forward-declare the class. Same with PlatformLayer.h if that's fixable.

We have huge build time problems because of over-eager #includes.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:365
> +void WebVideoFullscreenInterfaceAVKit::setSeekableRanges(const
WebCore::TimeRanges& timeRanges)

Need the WebCore::?

> Source/WebCore/platform/ios/WebVideoFullscreenModelMediaElement.mm:112
>	  
m_videoFullscreenInterface->setCurrentTime(m_mediaElement->currentTime(),
[[NSProcessInfo processInfo] systemUptime]);

What is the [[NSProcessInfo processInfo] systemUptime] thing for? Weird.

> Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.h:56
> +    virtual void setSeekableRangesVector(Vector<std::pair<double, double>>);


Vector&?