[webkit-reviews] review granted: [Bug 130704] Prevent 'removetrack' events from firing when all inband text tracks are removed. : [Attachment 227711] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 24 19:38:19 PDT 2014


Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 130704: Prevent 'removetrack' events from firing when all inband text
tracks are removed.
https://bugs.webkit.org/show_bug.cgi?id=130704

Attachment 227711: Patch
https://bugs.webkit.org/attachment.cgi?id=227711&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227711&action=review


> Source/WebCore/html/HTMLMediaElement.h:293
> +    void removeTextTrack(TextTrack*, bool scheduleEvent = true);

Is the default value used by any of the call sites?


More information about the webkit-reviews mailing list