[webkit-reviews] review granted: [Bug 130643] Subpixel rendering: Transition class Image (and its dependencies) from int to float to enable subpixel positioned/sized images. : [Attachment 227611] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 130643: Subpixel rendering: Transition class Image (and its dependencies)
from int to float to enable subpixel positioned/sized images.
https://bugs.webkit.org/show_bug.cgi?id=130643

Attachment 227611: Patch
https://bugs.webkit.org/attachment.cgi?id=227611&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227611&action=review


> Source/WebCore/platform/graphics/IntPoint.cpp:43
> +IntPoint::IntPoint(const FloatPoint& p)
> +    : m_x(clampToInteger(p.x()))
> +    , m_y(clampToInteger(p.y()))
> +{
> +}

Shouldn't this be up next to the other constructors?

> Source/WebCore/platform/graphics/IntSize.cpp:43
> +IntSize::IntSize(const FloatSize& s)
> +    : m_width(clampToInteger(s.width()))
> +    , m_height(clampToInteger(s.height()))
> +{
> +}

Ditto.

> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:128
> +    : m_data(IntSize(size)) // NOTE: The input here isn't important as
ImageBufferDataCG's constructor just ignores it.

I wonder if we should have a IntSize expectedIntegeralSize(const FloatSize&)
which asserts if not integral?

> LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:9

> +	     [feImage image-size="100.00x100.00"]

Can't we just be smarter about dumping?