[webkit-reviews] review granted: [Bug 130689] Add platform implementation for RTCOfferAnswerOptions and RTCOfferOptions : [Attachment 227675] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 130689: Add platform implementation for RTCOfferAnswerOptions and
RTCOfferOptions
https://bugs.webkit.org/show_bug.cgi?id=130689

Attachment 227675: Patch
https://bugs.webkit.org/attachment.cgi?id=227675&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227675&action=review


> Source/WebCore/Modules/mediastream/RTCOfferAnswerOptions.cpp:78
> +    RefPtr<RTCOfferOptionsPrivate> optionsPrivate =
RTCOfferOptionsPrivate::create();
> +    m_private = optionsPrivate;

Nit: is the local variable necessary?

> Source/WebCore/Modules/mediastream/RTCOfferAnswerOptions.h:54
> -private:
> -    String m_requestIdentity;
> +    RefPtr<RTCOfferAnswerOptionsPrivate> m_private;

This should remain private.

> Source/WebCore/Modules/mediastream/RTCOfferAnswerOptions.h:64
> +    int64_t offerToReceiveVideo() const { return
static_cast<RTCOfferOptionsPrivate*>(m_private.get())->offerToReceiveVideo(); }

> +    int64_t offerToReceiveAudio() const { return
static_cast<RTCOfferOptionsPrivate*>(m_private.get())->offerToReceiveAudio(); }

> +    bool voiceActivityDetection() const { return
static_cast<RTCOfferOptionsPrivate*>(m_private.get())->voiceActivityDetection()
; }
> +    bool iceRestart() const { return
static_cast<RTCOfferOptionsPrivate*>(m_private.get())->iceRestart(); }

Are these static_casts necessary? If so, please put the accessor
privateOfferOptions() in the base class and use it.

> Source/WebCore/platform/mediastream/RTCOfferAnswerOptionsPrivate.h:53
> +	   return;

This should be indented.