[webkit-reviews] review granted: [Bug 130314] Web Replay: capture and replay keyboard events : [Attachment 227530] the patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 130314: Web Replay: capture and replay keyboard events
https://bugs.webkit.org/show_bug.cgi?id=130314

Attachment 227530: the patch
https://bugs.webkit.org/attachment.cgi?id=227530&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=227530&action=review


r=me

> Source/WebCore/replay/SerializationMethods.cpp:148
> +    decodedValue = textWasDecoded ? KeypressCommand(commandName, text) :
KeypressCommand(commandName);

The origin os "textWasDecoded" is pretty cryptic, but I think its fine.

> Source/WebCore/replay/SerializationMethods.cpp:154
> +    PlatformKeyboardEventAppKit(const PlatformKeyboardEvent& event, bool
handledByInputMethod, Vector<KeypressCommand> commands)

Nit: Vector<>& commands