[webkit-reviews] review granted: [Bug 130674] fix prepare-ChangeLog after r166156. : [Attachment 227653] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 24 13:19:53 PDT 2014
Darin Adler <darin at apple.com> has granted László Langó
<llango.u-szeged at partner.samsung.com>'s request for review:
Bug 130674: fix prepare-ChangeLog after r166156.
https://bugs.webkit.org/show_bug.cgi?id=130674
Attachment 227653: Patch
https://bugs.webkit.org/attachment.cgi?id=227653&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227653&action=review
> Tools/Scripts/prepare-ChangeLog:1977
> - $end = $3 || $1;
> + if($4 gt "a") {
> + $end = $3 || $1;
> + }
Missing space before "(". But since this is perl you could write:
$end = $3 || $1 if $4 ne "a";
I think “ne” would be better than “gt”.
More information about the webkit-reviews
mailing list