[webkit-reviews] review requested: [Bug 129740] [EFL][WK2] Add ewk APIs to control TLS error policy on WebContext. : [Attachment 227659] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 24 09:43:57 PDT 2014


Peter Molnar <pmolnar.u-szeged at partner.samsung.com> has asked  for review:
Bug 129740: [EFL][WK2] Add ewk APIs to control TLS error policy on WebContext.
https://bugs.webkit.org/show_bug.cgi?id=129740

Attachment 227659: patch
https://bugs.webkit.org/attachment.cgi?id=227659&action=review

------- Additional Comments from Peter Molnar
<pmolnar.u-szeged at partner.samsung.com>
(In reply to comment #24)
> (From update of attachment 227445 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=227445&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_context.h:87
> > +/// Creates a type name for the Ewk_TLS_Error_Policy.
> 
> Use *//* instead of *///*.

Fixed.

(In reply to comment #25)
> (From update of attachment 227445 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=227445&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +	     [EFL] Add WK2 API to control TLS error policy on WebContext.
> 
> Let's change the bug title as below. You're not adding WK2 C APIs but ewk
APIs for EFL port.
> 
> [EFL][WK2] Add ewk APIs to control TLS error policy on WebContext.

Changed the bug title.


More information about the webkit-reviews mailing list