[webkit-reviews] review granted: [Bug 130660] When the mouse is upped after dragged out of shadowDOM, it should lose :active. : [Attachment 227625] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 24 01:06:39 PDT 2014


Darin Adler <darin at apple.com> has granted Sanghyup Lee <sh53.lee at samsung.com>'s
request for review:
Bug 130660: When the mouse is upped after dragged out of shadowDOM, it should
lose :active.
https://bugs.webkit.org/show_bug.cgi?id=130660

Attachment 227625: Patch
https://bugs.webkit.org/attachment.cgi?id=227625&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227625&action=review


> Source/WebCore/dom/Document.cpp:5844
> +	   for (Element* curr = oldActiveElement; curr; curr =
curr->parentOrShadowHostElement()) {

To set these flags we use the render tree. To clear them we are using the DOM
tree. I suspect this inconsistency could cause more problems than just this
one.


More information about the webkit-reviews mailing list