[webkit-reviews] review granted: [Bug 130573] [WK2] Refine WebKit2 BatteryStatus code : [Attachment 227405] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 23 08:18:15 PDT 2014


Anders Carlsson <andersca at apple.com> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 130573: [WK2] Refine WebKit2 BatteryStatus code
https://bugs.webkit.org/show_bug.cgi?id=130573

Attachment 227405: Patch
https://bugs.webkit.org/attachment.cgi?id=227405&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227405&action=review


> Source/WebKit2/WebProcess/Battery/WebBatteryManager.cpp:80
> +    for (auto it = m_pageSet.begin(), end = m_pageSet.end(); it != end;
++it) {

This can just use the range for syntax, 

for (auto* page : m_pageSet)

> Source/WebKit2/WebProcess/Battery/WebBatteryManager.cpp:91
> +    for (auto it = m_pageSet.begin(), end = m_pageSet.end(); it != end;
++it) {

Ditto.


More information about the webkit-reviews mailing list