[webkit-reviews] review granted: [Bug 130468] Webkit2 builds are forced with CMake, if Gtk+3 is used : [Attachment 227196] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 22 20:44:28 PDT 2014


Martin Robinson <mrobinson at webkit.org> has granted Tomeu Vizoso
<tomeu at tomeuvizoso.net>'s request for review:
Bug 130468: Webkit2 builds are forced with CMake, if Gtk+3 is used
https://bugs.webkit.org/show_bug.cgi?id=130468

Attachment 227196: Patch
https://bugs.webkit.org/attachment.cgi?id=227196&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=227196&action=review


> Source/cmake/OptionsGTK.cmake:114
> +    if (ENABLE_WEBKIT2)
> +	   set(ENABLE_PLUGIN_PROCESS ON)
> +    endif ()

Small nit. This doesn't need to be inside the if (NOT USE_GTK2) block


More information about the webkit-reviews mailing list