[webkit-reviews] review granted: [Bug 130585] [GTK] Build fails with GCC < 4.8.x : [Attachment 227429] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Mar 22 17:49:33 PDT 2014
Anders Carlsson <andersca at apple.com> has granted Andres Gomez Garcia
<agomez at igalia.com>'s request for review:
Bug 130585: [GTK] Build fails with GCC < 4.8.x
https://bugs.webkit.org/show_bug.cgi?id=130585
Attachment 227429: Patch
https://bugs.webkit.org/attachment.cgi?id=227429&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227429&action=review
> Source/WTF/wtf/gtk/RunLoopGtk.cpp:104
> + GMainLoopSource::createAndDeleteOnDestroy().schedule("[WebKit] RunLoop
work", std::function<void()>(std::bind(&RunLoop::performWork, this)),
> G_PRIORITY_DEFAULT, [this] { deref(); });
Please use a lambda with a RefPtr capture here instead of calling ref and
deref.
More information about the webkit-reviews
mailing list