[webkit-reviews] review granted: [Bug 126854] Remove String::deprecatedCharacters : [Attachment 227556] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 126854: Remove String::deprecatedCharacters
https://bugs.webkit.org/show_bug.cgi?id=126854

Attachment 227556: Patch
https://bugs.webkit.org/attachment.cgi?id=227556&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=227556&action=review


> Source/WebCore/platform/URL.cpp:1501
> +static bool containsOnlyASCII(StringView string)
> +{
> +    if (string.is8Bit())
> +	   return charactersAreAllASCII(string.characters8(), string.length());

> +    return charactersAreAllASCII(string.characters16(), string.length());
> +}

We should probably add a version of charactersAreAllASCII() that takes a
StringView.