[webkit-reviews] review granted: [Bug 130634] Remove Dead Stores from editing directory : [Attachment 227536] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 130634: Remove Dead Stores from editing directory
https://bugs.webkit.org/show_bug.cgi?id=130634

Attachment 227536: Patch
https://bugs.webkit.org/attachment.cgi?id=227536&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227536&action=review


> Source/WebCore/editing/CompositeEditCommand.cpp:-843
> -	       gapEnd = std::min(gapEnd, end);

I suspect the dead store here indicates a bug. I think that gapLen needs to be
recomputed. Instead of removing this line of code, we should add a line of
code:

    gapLen = gapEnd - gapStart;

But of course, we also need to construct a test case to demonstrate that the
code is incorrect, which could be difficult.