[webkit-reviews] review granted: [Bug 130635] Web Inspector: AXI: add other ARIA one-to-many relationships: owns, flowto, controls. : [Attachment 227541] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted James Craig <jcraig at apple.com>'s
request for review:
Bug 130635: Web Inspector: AXI: add other ARIA one-to-many relationships: owns,
flowto, controls.
https://bugs.webkit.org/show_bug.cgi?id=130635

Attachment 227541: patch
https://bugs.webkit.org/attachment.cgi?id=227541&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227541&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:1481
> +		       for (const auto& controlledElement : controlledElements)


No need to say "const auto&" here. Just "auto&" or "auto*" is better. And
"Element*" is shorter than "const auto&", so you could use that too.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1498
> +		       for (const auto& flowedElement : flowedElements)

Ditto.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1528
> +		       for (const auto& ownedElement : ownedElements)

Ditto.