[webkit-reviews] review granted: [Bug 130528] [WebKit2] Implement NetworkingContext::sourceApplicationAuditData() for WebKit2 : [Attachment 227499] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 130528: [WebKit2] Implement NetworkingContext::sourceApplicationAuditData()
for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=130528

Attachment 227499: Patch
https://bugs.webkit.org/attachment.cgi?id=227499&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227499&action=review


> Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:38
> +#if defined(__has_include) && __has_include(<xpc/private.h>)

no need for the defined() check

> Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:41
> +extern "C" void xpc_connection_get_audit_token(xpc_connection_t,
audit_token_t*);

I think we should be doing this *outside* of the #if, not in an #else, so we
get errors if the signature changes.

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:32
> +#include "WebProcess.h"
>  #include "WebPage.h"

this looks sorted wrong