[webkit-reviews] review requested: [Bug 130554] toThis() on a JSWorkerGlobalScope should return a JSProxy and not undefined : [Attachment 227498] Patch for Landing
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 21 15:20:53 PDT 2014
Michael Saboff <msaboff at apple.com> has asked for review:
Bug 130554: toThis() on a JSWorkerGlobalScope should return a JSProxy and not
undefined
https://bugs.webkit.org/show_bug.cgi?id=130554
Attachment 227498: Patch for Landing
https://bugs.webkit.org/attachment.cgi?id=227498&action=review
------- Additional Comments from Michael Saboff <msaboff at apple.com>
Already reviewed by Geoff.
Made two small fixes to reviewed patch:
1. Eliminated ASSERT in testapi.c that the object used to create the
GlobalObject is the same as the result from JSContextGetGlobalObject(context).
It is now a proxy to the original object.
2. Move the call to setGlobalThis() in both JSGlobalObject::finishCreation()
to after init has been called so our prototype can be created before we create
the JSProxy that needs the prototype.
These changes rubber stamped by Geoff.
More information about the webkit-reviews
mailing list