[webkit-reviews] review granted: [Bug 130484] [Webkit2] Add APIDownloadClient for download support. : [Attachment 227230] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 21 13:58:33 PDT 2014


Anders Carlsson <andersca at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 130484: [Webkit2] Add APIDownloadClient for download support.
https://bugs.webkit.org/show_bug.cgi?id=130484

Attachment 227230: Patch.
https://bugs.webkit.org/attachment.cgi?id=227230&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
Looks very good, but the WebContext constructor needs to initialize
m_downloadClient, something like:

, m_downloadClient(std::make_unique<API::DownloadClient>())


More information about the webkit-reviews mailing list