[webkit-reviews] review granted: [Bug 128684] Implement hasLiveStreamingContent property in WebAVPlayerController : [Attachment 227474] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 128684: Implement hasLiveStreamingContent property in WebAVPlayerController
https://bugs.webkit.org/show_bug.cgi?id=128684

Attachment 227474: Patch
https://bugs.webkit.org/attachment.cgi?id=227474&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227474&action=review


> Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.h:56
> +    virtual void setSeekableRangesVector(Vector<std::pair<double, double>>);


Pass a reference unless you're using std::move.

> Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.h:70
> +    

Blank space.

> Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm:71
> +    for (auto range : ranges)

const auto&

> Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm:72
> +	   timeRanges->add(range.first, range.second);

You should add some basic validity checking here (check that range end is >
range start, and any other invariants). Basically you should assume that data
coming over IPC is unsafe.

> Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.h:73
> +    virtual void setSeekableRanges(WebCore::TimeRanges&) override;

const WebCore::TimeRanges&