[webkit-reviews] review granted: [Bug 129814] Regression: AX: Don't expose role or notifications for invalid menus : [Attachment 227154] patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 129814: Regression: AX: Don't expose role or notifications for invalid
menus
https://bugs.webkit.org/show_bug.cgi?id=129814

Attachment 227154: patch
https://bugs.webkit.org/attachment.cgi?id=227154&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=227154&action=review


Lgtm. Please consider those suggestions below before landing

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:121
> +    m_object->updateChildrenIfNecessary();

For your consideration before landing: I wonder if you could fold this into
updateBackingStore(), so you don't need to call it explicitly here, and other
platforms get benefit from that too

> LayoutTests/ChangeLog:13
> +	   * platform/mac/accessibility/table-with-aria-role-expected.txt:

You can move this test expectation now to LayoutTests/accessibility, as there
should produce the same (platform independent) output now for all the platforms