[webkit-reviews] review granted: [Bug 130608] [GTK] Volume slider shows below the panel with videos in certain cases : [Attachment 227463] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 130608: [GTK] Volume slider shows below the panel with videos in certain
cases
https://bugs.webkit.org/show_bug.cgi?id=130608

Attachment 227463: Patch
https://bugs.webkit.org/attachment.cgi?id=227463&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=227463&action=review


Looks good. A couple small nits for landing:

> Source/WebCore/ChangeLog:9
> +	   We need to delay the moment we check if the volume slider show
> +	   show up or down because if the video was not visible when we were

Double "show"

> LayoutTests/media/video-initially-hidden-volume-slider-up-expected.txt:5
> +** Test that the volume slider is rendered correctly if video is brought to
foreground **
> +** Move mouse on top of the mute button **
> +** Ensure layout is done after mouse move **
> +** The volume slider should not be positioned below the panel **

I think these can just be code comments.