[webkit-reviews] review granted: [Bug 50881] Optimize FEGaussian blur : [Attachment 227342] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 21 10:08:58 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Adenilson Cavalcanti
Silva <savagobr at yahoo.com>'s request for review:
Bug 50881: Optimize FEGaussian blur
https://bugs.webkit.org/show_bug.cgi?id=50881

Attachment 227342: Patch
https://bugs.webkit.org/attachment.cgi?id=227342&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227342&action=review


> Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:95
> +inline void boxBlurAlphaOnly(Uint8ClampedArray* srcPixelArray,
Uint8ClampedArray* dstPixelArray,
> +    unsigned dx, int& dxLeft, int& dxRight, int& stride, int& strideLine,
int& effectWidth, int& effectHeight, const int& maxKernelSize)

The Uint8ClampedArray* should be Uint8ClampedArray& (in the caller too).


More information about the webkit-reviews mailing list