[webkit-reviews] review granted: [Bug 130547] WindowFeatures.{x|y|width|height} are not initialized : [Attachment 227436] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 130547: WindowFeatures.{x|y|width|height} are not initialized
https://bugs.webkit.org/show_bug.cgi?id=130547

Attachment 227436: Patch v1
https://bugs.webkit.org/attachment.cgi?id=227436&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227436&action=review


I’m saying review+ but this change doesn’t seem to have much benefit.

> Source/WebCore/ChangeLog:13
> +	   - Initialize x, y, width, height in String constructor.

Why? To make automated code analysis tools happy? To actually fix a bug?
Where’s the test case for the bug?