[webkit-reviews] review denied: [Bug 130574] [CSS Regions] The background of children of scrollable elements flowed into regions is not properly scrolled : [Attachment 227433] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Radu Stavila <stavila at adobe.com>'s
request for review:
Bug 130574: [CSS Regions] The background of children of scrollable elements
flowed into regions is not properly scrolled
https://bugs.webkit.org/show_bug.cgi?id=130574

Attachment 227433: Patch
https://bugs.webkit.org/attachment.cgi?id=227433&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227433&action=review


> Source/WebCore/rendering/RenderNamedFlowThread.cpp:307
> +    // Take the scrolled offset of this object's parents into consideration.

> +    IntSize scrolledContentOffset;
> +    RenderElement* parent = box.parent();
> +    while (parent) {
> +	   if (parent->isBox()) {
> +	       RenderBox* parentBox = toRenderBox(parent);
> +	       if (parentBox->isRenderNamedFlowThread()) {

Don't we have a function to get the enclosing named flow thread for a box?
Pretty sure we do, in which case writing this loop yourself seems like extra
code?