[webkit-reviews] review granted: [Bug 130554] toThis() on a JSWorkerGlobalScope should return a JSProxy and not undefined : [Attachment 227382] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 130554: toThis() on a JSWorkerGlobalScope should return a JSProxy and not
undefined
https://bugs.webkit.org/show_bug.cgi?id=130554

Attachment 227382: Patch
https://bugs.webkit.org/attachment.cgi?id=227382&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227382&action=review


r=me with a bug fix below, and please fix the build before landing.

> Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp:134
> +    if (classInfo == JSProxy::info())
> +	   return
static_cast<JSDedicatedWorkerGlobalScope*>(jsCast<JSProxy*>(asObject(value))->t
arget());

This needs to be jsDynamicCast<JSDedicatedWorkerGlobalScope*> because it's not
guaranteed that all proxies proxy to JSDedicatedWorkerGlobalScope.