[webkit-reviews] review granted: [Bug 130553] Change CodeGeneratorJS.pm special cases for "DOMWindow" to be general purpose : [Attachment 227374] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 130553: Change CodeGeneratorJS.pm special cases for "DOMWindow" to be
general purpose
https://bugs.webkit.org/show_bug.cgi?id=130553

Attachment 227374: Patch
https://bugs.webkit.org/attachment.cgi?id=227374&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227374&action=review


r=me

> Source/WebCore/bindings/scripts/IDLAttributes.txt:46
> +CustomProxyToJSObject

Seems like we should just call this "CustomToJSObject". Even though only
proxies happen to use this feature, the feature doesn't need to be tightly
coupled to proxies.