[webkit-reviews] review granted: [Bug 129853] Move to using std::unique_ptr for EFL objects. : [Attachment 227292] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 20 17:02:21 PDT 2014


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Hyowon Kim
<hw1008.kim at samsung.com>'s request for review:
Bug 129853: Move to using std::unique_ptr for EFL objects.
https://bugs.webkit.org/show_bug.cgi?id=129853

Attachment 227292: Patch
https://bugs.webkit.org/attachment.cgi?id=227292&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227292&action=review


Andersca already set r+ed. Anyway, LGTM. r+ again.

> Source/WTF/wtf/efl/UniquePtrEfl.h:2
> +    Copyright (C) 2014 Samsung Electronics

We prefer to use BSD rather than LGPL. Can't we use BSD ?


More information about the webkit-reviews mailing list