[webkit-reviews] review granted: [Bug 130350] [CSS Shapes] clamp RasterShape shapeMargin to reference box size : [Attachment 227345] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 130350: [CSS Shapes] clamp RasterShape shapeMargin to reference box size
https://bugs.webkit.org/show_bug.cgi?id=130350

Attachment 227345: Patch
https://bugs.webkit.org/attachment.cgi?id=227345&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227345&action=review


> Source/WebCore/rendering/shapes/Shape.h:71
> -    static PassOwnPtr<Shape> createRasterShape(Image*, float threshold,
const LayoutRect& drawRect, const LayoutRect& clipRect, WritingMode, Length
margin, Length padding);
> +    static PassOwnPtr<Shape> createRasterShape(Image*, float threshold,
const LayoutRect& imageRect, const LayoutRect& marginRect, WritingMode, Length
margin, Length padding);

Interesting that Shape.cpp already had that change.