[webkit-reviews] review denied: [Bug 20083] end and then right arrow moves one character too far : [Attachment 227277] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 20 15:38:07 PDT 2014
Ryosuke Niwa <rniwa at webkit.org> has denied Deepak Mittal
<deepak.m1 at samsung.com>'s request for review:
Bug 20083: end and then right arrow moves one character too far
https://bugs.webkit.org/show_bug.cgi?id=20083
Attachment 227277: Patch
https://bugs.webkit.org/attachment.cgi?id=227277&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=227277&action=review
> Source/WebCore/editing/VisiblePosition.cpp:442
> - ASSERT(right != *this);
> + // The position will be same when we are at the end of the line by
selecting
> + // The end key.and then we select right arrow key.
> + // ASSERT(right != *this);
Again, this is wrong.
More information about the webkit-reviews
mailing list