[webkit-reviews] review granted: [Bug 129395] Web Replay: capture and replay mouse events : [Attachment 227320] revised patch with test.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 20 14:15:23 PDT 2014
Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 129395: Web Replay: capture and replay mouse events
https://bugs.webkit.org/show_bug.cgi?id=129395
Attachment 227320: revised patch with test.
https://bugs.webkit.org/attachment.cgi?id=227320&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=227320&action=review
r=me
> ManualTests/inspector/replay-mouse-events.html:44
> + var block = createBlock(hex_md5(JSON.stringify(obj)));
> + block.textContent = glyphForType(event.type);
> + var blocksContainer = document.getElementById("blocks");
> + blocksContainer.appendChild(block);
> +
> + var hashLabel = document.getElementById("hash");
> + hash.textContent = hex_md5(JSON.stringify(dumpedEvents));
Nit: Probably should be indented.
> ManualTests/inspector/replay-mouse-events.html:80
> + </style>
Nit: Probably should match indentation of <style>.
More information about the webkit-reviews
mailing list