[webkit-reviews] review granted: [Bug 130530] Update iOS input method code to use new cross-platform async functions : [Attachment 227328] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 20 14:07:21 PDT 2014


Enrica Casucci <enrica at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 130530: Update iOS input method code to use new cross-platform async
functions
https://bugs.webkit.org/show_bug.cgi?id=130530

Attachment 227328: proposed patch
https://bugs.webkit.org/attachment.cgi?id=227328&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227328&action=review


Looks good.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1510
> +    _page->insertTextAsync(aStringValue, EditingRange());

Are these methods implemented for both iOS and Mac?


More information about the webkit-reviews mailing list