[webkit-reviews] review granted: [Bug 130532] Add a flushing mechanism for the WebVTTParser : [Attachment 227326] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 20 13:54:13 PDT 2014
Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 130532: Add a flushing mechanism for the WebVTTParser
https://bugs.webkit.org/show_bug.cgi?id=130532
Attachment 227326: Patch
https://bugs.webkit.org/attachment.cgi?id=227326&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227326&action=review
> Source/WebCore/ChangeLog:64
> +2014-03-20 Brent Fulgham <bfulgham at apple.com>
> +
> + Need a short description (OOPS!).
> + Need the bug URL (OOPS!).
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + Tests: http/tests/media/track/track-webvtt-slow-loading-2.html
> + http/tests/media/track/track-webvtt-slow-loading.html
> +
> + * CMakeLists.txt:
> + * Configurations/FeatureDefines.xcconfig:
> + * GNUmakefile.list.am:
> + * WebCore.vcxproj/WebCore.vcxproj:
> + * WebCore.vcxproj/WebCore.vcxproj.filters:
> + * WebCore.xcodeproj/project.pbxproj:
> + * html/track/BufferedLineReader.cpp: Added.
> + * html/track/BufferedLineReader.h: Added.
> + * html/track/TextTrackRegion.cpp:
> + * html/track/VTTCue.cpp:
> + * html/track/WebVTTParser.cpp:
> + * html/track/WebVTTParser.h:
> + * loader/TextTrackLoader.cpp:
Oops!
More information about the webkit-reviews
mailing list