[webkit-reviews] review denied: [Bug 130273] Implement contentInset for Mac WebKit2 : [Attachment 227319] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 20 13:34:51 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 130273: Implement contentInset for Mac WebKit2
https://bugs.webkit.org/show_bug.cgi?id=130273

Attachment 227319: Patch
https://bugs.webkit.org/attachment.cgi?id=227319&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227319&action=review


> Source/WebCore/page/Page.h:282
> +    void setTopContentInset(float contentInset) { m_topContentInset =
contentInset; }

Doesn't this need to cause layout or other rejiggery?

> Source/WebCore/platform/ScrollView.cpp:280
> +	   return visibleCOntentSize;

visibleCOntentSize

> Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:84
> + at property (readwrite) CGFloat topContentInset;

Should be on WKWebView.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3303
> +- (void)setTopContentInset:(CGFloat)contentInset
> +{
> +    _data->_page->setTopContentInset(contentInset);
> +}
> +
> +- (CGFloat)topContentInset
> +{
> +    return _data->_page->topContentInset();
> +}

We're not using WKView any more


More information about the webkit-reviews mailing list