[webkit-reviews] review granted: [Bug 128624] Merge AtomicString, Identifier : [Attachment 227312] Patch, with speculative Windows build fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 20 12:03:15 PDT 2014


Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 128624: Merge AtomicString, Identifier
https://bugs.webkit.org/show_bug.cgi?id=128624

Attachment 227312: Patch, with speculative Windows build fix
https://bugs.webkit.org/attachment.cgi?id=227312&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227312&action=review


r=me if it blends

> Source/JavaScriptCore/ChangeLog:9
> +	   WTF::StringImpl currently supports two uniquing mechanism -
AtomicString and
> +	   Identifer - that is one too many.

So, you're saying we should unique our uniquing?


More information about the webkit-reviews mailing list