[webkit-reviews] review denied: [Bug 129627] Web Inspector: probe sidebar should use overflow:scroll and split space evenly : [Attachment 227251] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Katie Madonna
<madonnk at gmail.com>'s request for review:
Bug 129627: Web Inspector: probe sidebar should use overflow:scroll and split
space evenly
https://bugs.webkit.org/show_bug.cgi?id=129627

Attachment 227251: Patch
https://bugs.webkit.org/attachment.cgi?id=227251&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=227251&action=review


Some tweaks and questions remain before this should land. But looking good!

> Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.css:79
> +    min-height: 250px;

What happens if this min-height is triggered? Will that cause double
scrollbars? That would be bad.

> Source/WebInspectorUI/UserInterface/Views/ProbeSetDataGrid.css:39
> +.details-section.probe-set .data-grid .data-container {
> +    top: 23px;
> +}

This is a layering violation. details-section is not related and at a higher
level than this data grid. This rule should be in ProbeDetailsSidebarPanel.css.