[webkit-reviews] review denied: [Bug 130099] Unify private browsing with sessions : [Attachment 226960] gtk build fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 20 10:25:25 PDT 2014


Alexey Proskuryakov <ap at webkit.org> has denied Martin Hock <mhock at apple.com>'s
request for review:
Bug 130099: Unify private browsing with sessions
https://bugs.webkit.org/show_bug.cgi?id=130099

Attachment 226960: gtk build fix
https://bugs.webkit.org/attachment.cgi?id=226960&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
The refactoring looks like a good idea. This patch also includes a bug fix,
which is not the right way to fix it. As discussed in person, please fix it in
a separate bug.

When session ID is set in createNewPage, it should be captured in
WebPageCreationParameters, and passed back to WebProcess as a response to
createNewPage.


More information about the webkit-reviews mailing list